Adds diesel support for Ewkb type for postgis #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, code looks good! Could you check the failing test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition allows for the seamless use of the Ewkb format in diesel to map to postgis geometry and geography types. Because postgis emits Ewkb for geometry types, we can make the wkb module an entrypoint into the GeoRust ecosystem and allow easy conversion to other types. While it is feasible to make any type that implements ToWkb and has a To* trait from wkb a base type in diesel, Ewkb is the most flexible because it is the base emission from postgis.