Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RDP recursion bug #2 #950

Merged
merged 3 commits into from Dec 6, 2022
Merged

Fix RDP recursion bug #2 #950

merged 3 commits into from Dec 6, 2022

Conversation

michaelkirk
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Supersedes #941

I rebased #940 against main to include #942 and added a guard to avoid the spurious assertion failure introduced in c61abfa

urschrei
urschrei approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thank you!

@michaelkirk michaelkirk mentioned this pull request Dec 6, 2022
Closed
2 tasks
@michaelkirk
Copy link
Member Author

bors r=urschrei

@bors
Copy link
Contributor

bors bot commented Dec 6, 2022

Build succeeded:

@bors bors bot merged commit 1821d7e into main Dec 6, 2022
@bors bors bot deleted the mkirk/rdp_fix branch December 6, 2022 19:30
@michaelkirk michaelkirk mentioned this pull request Dec 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urschrei urschrei urschrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelkirk @urschrei