Utilize const generics to pass settings to VW algorithm. #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably a microoptimization, but this makes the stack frames a little bit smaller since we remove an unneeded argument.
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Dec 6, 2022
950: Fix RDP recursion bug #2 r=urschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Supersedes #941 I rebased #940 against main to include #942 and added a guard to avoid the spurious assertion failure introduced in c61abfa Co-authored-by: Stephan Hügel <shugel@tcd.ie> Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a microoptimization, but this makes the stack frames a little bit smaller since we remove an unneeded argument. And maybe allows the compiler to better optimize the conditional checks with these values.
CHANGES.mdif knowledge of this change could be valuable to users.