geo/geo bump proj to 0.27.0 #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM, but I'm also not very concerned about publishing a breaking release for geo. I'd also be fine to just strictly bump proj without the range. My position on this is different with geo-types - which is used across a lot of other crates. I'm much more willing to put effort into not breaking geo-types. I'll wait until tomorrow to merge in case anyone else wants to weigh in. |
Great that is my preference..fixed. |
martinfrances107
changed the title
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 24, 2022
850: #849 Bump the minor version of approx. r=michaelkirk a=martinfrances107 - [x ] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). --- Consitently and in many Cargo.toml files - bump the minor version of approx. -approx = "0.4.0" +approx = "0.5.1" 857: geo/geo bump proj to 0.27.0 r=michaelkirk a=martinfrances107 The is a ongoing discussion in #856 about how to signal to the wider community that our dependencies are changing. But this is issue follows the pattern developed in #850 859: bump geojson to 0.23.0 r=michaelkirk a=martinfrances107 geojson is a internal dev-dependency. 860: Hide test artifact. r=michaelkirk a=martinfrances107 - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). --- Alter .gitignore to remove a test artefact. Co-authored-by: Martin <martinfrances107@hotmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jun 24, 2022
850: #849 Bump the minor version of approx. r=michaelkirk a=martinfrances107 - [x ] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md). --- Consitently and in many Cargo.toml files - bump the minor version of approx. -approx = "0.4.0" +approx = "0.5.1" 857: geo/geo bump proj to 0.27.0 r=michaelkirk a=martinfrances107 The is a ongoing discussion in #856 about how to signal to the wider community that our dependencies are changing. But this is issue follows the pattern developed in #850 Co-authored-by: Martin <martinfrances107@hotmail.com>
|
Canceled. |
|
bors retry I pushed up a new commit to your branch to adapt to the latest proj. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is a ongoing discussion in #856 about how to signal to the wider community that our dependencies are changing.
But this is issue follows the pattern developed in #850