Require matching data types in MDArray::read_into_slice #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianBeilschmidt
requested changes
Sep 2, 2022
lnicola
force-pushed
the
mdarray-read-as-check-type
branch
from
c01052a
to
76c4974
Compare
lnicola
force-pushed
the
mdarray-read-as-check-type
branch
from
76c4974
to
1fe8629
Compare
ChristianBeilschmidt
approved these changes
Sep 2, 2022
|
Looks more robust now. |
|
bors merge |
It does, I included that part in It actually didn't need ASAN to crash, it was a blatant buffer overrun. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.We don't support
GEDTC_COMPOUNDanyway because of theGdalTypebound.This is stricter than it could be, but should be fine as a quick workaround for #290. We should pass in the data type of the buffer, but it wasn't obvious to me how to do that.Fixes #290