New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade ci #234
upgrade ci #234
Conversation
Some more work is needed here, but I don't have time right now. Will come back here later |
Test pass in gdal 3.0; then in gdal 3.2 and gdal 3.3; test_sql_with_dialect is broken.
and in gdal 3.4 a second test breaks; auto_identify :
Which shows why it is a good idea to test against as many versions as possible. :) |
Ok. so the problem with one of the function was probably a driver not available on the minimal ubuntu base, swapping to the full image solved the problem. |
great work! |
Any idea how to fix it? I'm not very familiar with that side of the API. |
I was able to get the test to pass with these changes: I've never used the WKT SRS format before. Is it possible that it changed with the more recent versions? |
update WKT representation to fix test on gdal 3.4
bors try |
Excellent, thanks! We do have all green lights now. Maybe it would be nice to add a note about this in the release notes when gdal 3.4 bindings are added? Unfortunately I can't find anything in the release notes upstream to explain the change in behaviour. I'm not even sure if it is a change in gdal or proj? |
I don't know either. One data point I have is that I was actually seeing this same error locally with gdal 3.3 and proj 8.2 (on apple aarch64). So that might point to it being related to the underlying proj instance... maybe 🤷 |
yes, I'm inclined to think that is a change in proj. I just checked and the docker image for gdal 3.4 uses proj 8.2 while the 3.3 version uses 8.0.1. Thanks again! |
thanks! this a huge improvement. I also think think it depends on the proj version. |
bors r+ |
234: upgrade ci r=jdroenner a=geohardtke CI should now build and test against gdal 3.0, 3.1, 3.2, 3.3 and 3.4 Unfortunately some tests are now failing. Any idea? Co-authored-by: Leonardo Hardtke <leonardo.hardtke@des.qld.gov.au> Co-authored-by: Michael Kirk <michael.code@endoftheworl.de> Co-authored-by: geohardtke <48337686+geohardtke@users.noreply.github.com>
Timed out. |
tryTimed out. |
1 similar comment
tryTimed out. |
bors try |
the ci is not happy with some of the tests :( |
bors retry |
234: upgrade ci r=lnicola a=geohardtke CI should now build and test against gdal 3.0, 3.1, 3.2, 3.3 and 3.4 Unfortunately some tests are now failing. Any idea? Co-authored-by: Leonardo Hardtke <leonardo.hardtke@des.qld.gov.au> Co-authored-by: Michael Kirk <michael.code@endoftheworl.de> Co-authored-by: geohardtke <48337686+geohardtke@users.noreply.github.com>
We might have to merge this manually, but I'd rebase it first. |
yes. just thought it should try again 😆 |
Timed out. |
i will rebase and merge it later |
ok now we have a new issue. Thanks clippy -_- What about adding a ::zero() method to GdalType or use num_traits ::zero() to initialize generic vectors? |
@jdroenner The |
i think we would have to make the FFI call in the same method. we can not use a &mut ref and pass it to the other method. |
@rmanoka this way it works. Don't know what i like better. |
bors try |
@jdroenner I like your approach; it's a bit of copied code, but safer. We used |
Another option, if you would like to not have copied code: move the common |
lets use it like this then |
bors merge |
234: upgrade ci r=jdroenner a=geohardtke CI should now build and test against gdal 3.0, 3.1, 3.2, 3.3 and 3.4 Unfortunately some tests are now failing. Any idea? Co-authored-by: Leonardo Hardtke <leonardo.hardtke@des.qld.gov.au> Co-authored-by: Michael Kirk <michael.code@endoftheworl.de> Co-authored-by: geohardtke <48337686+geohardtke@users.noreply.github.com> Co-authored-by: Johannes Drönner <droenner@mathematik.uni-marburg.de>
tryTimed out. |
Timed out. |
i guess the CI is just to much for bors |
329: Drop `trybuild` test r=jdroenner a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Follow-up to #236 Closes #312 `trybuild` sounds nice, however: - it doesn't work (out of the box) with multiple compiler versions, so it breaks when upgrading compilers: #234 - when testing with `--all-features`, it causes the code to be rebuilt twice - I've seen it give some weird errors in unusual circumstances (under `gdb`, maybe?) - it's completely broken for `@metasim` (#312), but not on CI, see also #312 (comment) - 1.5 years later, we still only have one test Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
CI should now build and test against gdal 3.0, 3.1, 3.2, 3.3 and 3.4
Unfortunately some tests are now failing. Any idea?