OpenCage provider: use no_annotations=1 as returned data is not used #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid this might count as a breaking change, because it would affect the contents of the Is the benefit from disabling these by default really prominent? |
|
Well, it seems to reduce mean request time in tests by 20%, so I guess that's something. I'm merging this, but will add a new method param to switch annotations and will make it on by default, in order to not break backwards compatibility. |
|
Sounds good. Thanks a lot. |
KostyaEsmukov
added a commit
that referenced
this pull request
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCage results include https://opencagedata.com/api#annotations data by default. As this data isn't put into the Location response object it can be skipped in the request.