Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HERE v7 geocoding service #433

Merged
merged 13 commits into from Apr 10, 2021
Merged

Add support for HERE v7 geocoding service #433

merged 13 commits into from Apr 10, 2021

Conversation

pratheekrebala
Copy link
Contributor

Addressing #430

Still needs documentation and tests

KostyaEsmukov
KostyaEsmukov requested changes Jul 26, 2020
View reviewed changes
Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! I left some minor comments. After adding docs and tests this should be good to go!

Thank you for working on this!

geopy/geocoders/herev7.py Outdated Show resolved Hide resolved
geopy/geocoders/herev7.py Outdated Show resolved Hide resolved
geopy/geocoders/herev7.py Outdated Show resolved Hide resolved
geopy/geocoders/herev7.py Outdated Show resolved Hide resolved
geopy/geocoders/herev7.py Outdated Show resolved Hide resolved
@pratheekrebala
Copy link
Contributor Author

Thank you for your patience on this. I'm working on adding tests.

@KostyaEsmukov KostyaEsmukov added this to the 2.1 milestone Aug 21, 2020
@KostyaEsmukov KostyaEsmukov modified the milestones: 2.1, 2.2 Dec 20, 2020
KostyaEsmukov
KostyaEsmukov approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm merging this, but will do some changes on top in master.

@KostyaEsmukov KostyaEsmukov merged commit 950d56a into geopy:master Apr 10, 2021
KostyaEsmukov added a commit that referenced this pull request Apr 10, 2021
@KostyaEsmukov
HereV7: fix incorrect documentation + make params conventional (#433)
6f8bcc6
KostyaEsmukov added a commit that referenced this pull request Apr 10, 2021
@KostyaEsmukov
HereV7: move to the here.py module (#433)
85b2352
@KostyaEsmukov KostyaEsmukov mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KostyaEsmukov KostyaEsmukov KostyaEsmukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pratheekrebala @KostyaEsmukov