Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: Default value of observed parameter in dissolve #3192

Open
m-richards opened this issue Feb 18, 2024 · 0 comments
Open

COMPAT: Default value of observed parameter in dissolve #3192

m-richards opened this issue Feb 18, 2024 · 0 comments

Comments

@m-richards
Copy link
Member

On pandas main, the default value of observed in df.groupby has changed from False to True (pandas-dev/pandas#57330) along with a deprecation period. In dissolve we should probably make the same change, also with a deprecation period.

The future warning didn't show up in our tests because we supply observed explicitly as part of kwarg forwaring into two calls to groupby, one for the geometry and the other for the attributes.

@m-richards m-richards changed the title COMPAT: COMPAT: Default value of observed parameter in dissolve Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant