Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependency between UnitView and data flow / data sources. #192

Open
tuner opened this issue Nov 20, 2023 · 2 comments · May be fixed by #193
Open

Circular dependency between UnitView and data flow / data sources. #192

tuner opened this issue Nov 20, 2023 · 2 comments · May be fixed by #193
Labels
core Related to the Core package

Comments

@tuner
Copy link
Member

tuner commented Nov 20, 2023 •
edited

flowBuilder.js and SingleAxisLazySource import UnitView for instanceof UnitView expressions. This dependency may cause problems in some environments. instanceof could be replaced with some other pattern. However, I'm unable to reproduce the circular dependency error, which makes testing of the fix somewhat difficult...
@tuner tuner added the core Related to the Core package label Nov 20, 2023
@tuner tuner linked a pull request Nov 20, 2023 that will close this issue
Open
@tuner
Copy link
Member Author

tuner commented Nov 20, 2023

Btw, dependencies can be visualized using https://github.com/sverweij/dependency-cruiser

@tuner
Copy link
Member Author

tuner commented Nov 20, 2023

It seems that there was no circular dependency between UnitView and data flow after all. However, there's some other circlar stuff.

Overall, there are quite a bit of dependencies that could be optimized.

The following diagram starts from ViewFactory:
dependency-graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Related to the Core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: break cyclic dependency between flowBuilder and UnitView genome-spy/genome-spy
1 participant
@tuner