Improve copy_data error handling #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure an error in put_copy_end doesn't lose the original exception. Use a dedicated error class PG::LostCopyState for errors due to another query while COPYing and mention that it's probably due to another query. Previously the "no COPY in progress" PG::Error was less specific. Remove transactions around the "another query" specs, previously the put_copy_data direction had a double fault due to another query while transaction is in error state. Use discard_result which we have now and which does essentially what previous error handling did. Cleanup temporary tables after running. Move definition of error classes to exception.rb, where they better fit into.
larskanis
force-pushed
the
improve_copy_data
branch
from
3eb55cf
to
1563e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure an error in put_copy_end doesn't lose the original exception.
Use a dedicated error class PG::LostCopyState for errors due to another query while COPYing and mention that it's probably due to another query. Previously the "no COPY in progress" PG::Error was less specific.
Remove transactions around the "another query" specs, previously the put_copy_data direction had a double fault due to another query while transaction is in error state.
Use discard_result which we have now and which does essentially what previous error handling did.
Cleanup temporary tables after running.
Move definition of error classes to exception.rb, where they better fit into.