Fix transaction leak on early break/return #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a return/break inside the Connection#transaction block would cause the transaction to neither commit nor rollback after its begin, effectively causing the transaction to remain open and leak into the next calls made to the connection. That's because `#transaction` used `rescue/else`, and the `else` block won't get executed in case of early break/return. Here's the problem: ``` irb(main):001:1* def transaction irb(main):002:1* p 'pre' irb(main):003:1* yield irb(main):004:1* p 'post' irb(main):005:1* rescue irb(main):006:1* p 'rescue' irb(main):007:1* else irb(main):008:1* p 'else' irb(main):009:1* ensure irb(main):010:1* p 'ensure' irb(main):011:0> end => :transaction irb(main):012:1* transaction do irb(main):013:1* p 'in' irb(main):014:1* break irb(main):015:0> end "pre" "in" "ensure" => nil ``` Using `ensure` instead of `rescue`'s `else` fixes the problem.
larskanis
requested changes
Jun 15, 2022
spec/pg/connection_spec.rb
Outdated
| @conn.exec( "CREATE TABLE pie ( flavor TEXT )" ) | ||
|
|
||
| begin | ||
| res = @conn.transaction do |
There was a problem hiding this comment.
This assignment and the one above are unnecessary. Could you please remove them.
There was a problem hiding this comment.
Good catch thanks, removed in 48bc9b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a return/break inside the Connection#transaction block would cause the transaction to neither commit nor rollback after its begin, effectively causing the transaction to remain open and leak into the next calls made to the connection and generating warnings:
WARNING: there is already a transaction in progress.That's because
#transactionusedrescue/else, and theelseblock won't get executed in case of early break/return.Here's the problem:
Using
ensureinstead ofrescue'selsefixes the problem.