Handle connection timeout and multiple addresses per host #459
+442
−290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes that PG.connect can block forever, when the connection can not be established on Windows. There was no test case for this error before, but the "connects using URI with multiple hosts" failed since commit c008f3c.
and avoid postgresql-11 and earlier on Windows which raises just "timeout expired"
These specs don't run reliable with sync methods. They sometimes block indefinitely.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is much bigger than intended. It includes #453, since
hostaddrandconninfo_parseare a dependency of this PR.As written in #450 (comment) there is a compatibility issue in libpq, which doesn't allow to combine non-blocking connection establishment, multiple hosts and the
connect_timeoutoption.This PR solves the issue by splitting the host string into single hosts and calling the underlying libpq with each single host, one after another. That way the timeout can be applied per host.
This PR also replaces our own URI and connection string parser by libpq's
conninfo_parse. It simplifies our connection string handling.This PR also separates specs, that are only applicable to the
PG::Connection.async_exec=truecase. This is necessary to verify that multiple connections attempts are executed.This PR also fixes issue #458, which I stumbled upon in one of the new test cases.
This PR also fixes issue #452, so that two connection attempts are made, when a single host has both IPv4 and IPv6 addresses.
Fixes #452
Fixes #450
Fixes #458
Closes #453