Handle client error after all data consumed in #copy_data for output #455
Conversation
During #copy_data for output, if an exception is raised after consuming all the data from get_copy_data, then the subsequent cleanup triggers a "no COPY in progress" error when it tries to call get_copy_data again, which causes the original exception to be lost. Fix by ignoring PG::Error during get_copy_data cleanup.
Previously this test failed on TruffleRuby because the finally raised exception was a RuntimeError with no message. It looks like TruffleRuby doesn't raise the originally caught exception in this case, ie if there is an intermediate exception between the original one and the raise with no args. Fix by explicitly raising the originally caught exception.
|
Thank you for fixing another corner case of the copy function!
|
|
You are most welcome, thanks. |
During #copy_data for output, if an exception is raised after consuming all the
data from get_copy_data, then the subsequent cleanup triggers a "no COPY in
progress" error when it tries to call get_copy_data again, which causes the
original exception to be lost.
Fix by ignoring PG::Error during get_copy_data cleanup.