Don't cache the socket-IO while connection setup #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskanis
force-pushed
the
add-ssl
branch
2 times, most recently
from
b88d59b
to
8294c14
Compare
The file_no of the socket IO can change while connecting. This can happen when alternative hosts are tried, while GSS authentication and when falling back to unencrypted in sslmode:prefer . Therefore expire the socket IO at each connect_poll and reset_poll call. Caching the IO previosly led to occasional errors kind of: Errno::EBADF: Bad file descriptor With the recreation of an IO object per connect_poll the fileno can change in the TcpGateScheduler when running on Windows. I didn't dig deeper why this happens, but it fails in spec "with a Fiber scheduler connects several times concurrently" and sometimes in other specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file_no of the socket IO can change while connecting. This can happen when alternative hosts are tried,
while GSS authentication and when falling back to unencrypted in
sslmode:prefer. Therefore expire the socket IO at eachconnect_pollandreset_pollcall.Caching the IO previosly led to occasional errors kind of:
Errno::EBADF: Bad file descriptor