Remove FL_TEST and FL_SET #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object flags are pretty internal information so we shouldn't be checking them (if possible). In this case, we don't need to check the status of EXIVAR because `rb_copy_generic_ivar` will check the flag and return if there are no ivars to copy[1] and will set the flag on the cloned object if it did copy[2] Just for some background, `FL_EXIVAR` flag indicates that an object has instance variables, but only objects that are not of the type `T_OBJECT`, `T_CLASS`, or `T_MODULE`. This type of knowledge is really an implementation detail, so I think C extensions should not know it or use it. 1. https://github.com/ruby/ruby/blob/24909f5b3de10b6f0b6f9acbf44ed347ccabb7e7/variable.c#L1725-L1727 2. https://github.com/ruby/ruby/blob/24909f5b3de10b6f0b6f9acbf44ed347ccabb7e7/variable.c#L1741
|
Make sense, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object flags are pretty internal information so we shouldn't be checking
them (if possible). In this case, we don't need to check the status of
EXIVAR because
rb_copy_generic_ivarwill check the flag and return ifthere are no ivars to copy[1] and will set the flag on the cloned object
if it did copy[2]
Just for some background,
FL_EXIVARflag indicates that an object hasinstance variables, but only objects that are not of the type
T_OBJECT,T_CLASS, orT_MODULE. This type of knowledge is really animplementation detail, so I think C extensions should not know it or use
it.