Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently building a data streaming system and would like to use the streaming replication protocol.
The biggest change would be the addition of
PGRES_COPY_BOTH
in thepgconn_get_last_result
function, marking it as an empty result. Otherwise fetching a result would never return since it would be expecting a result to come in.The
PG::LogicalReplication
may not be the best spot for this code and am happy to take it out.