Skip to content

Add pg_get_result_enc_idx #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Conversation

jeremyevans
Copy link
Contributor

This can be used by sequel_pg to get the encoding index, as discussed in jeremyevans/sequel_pg#34.

I've prepared an update to sequel_pg to use this function:

$ ruby24 -I /data/code/external/ruby-pg/lib bin/sequel postgres:///?user=sequel_test -c 'p $LOADED_FEATURES.grep(/pg.*.so\z/); p DB[:s].get(:s)'
["/data/code/external/ruby-pg/lib/pg_ext.so", "/usr/local/lib/ruby/gems/2.4/gems/sequel_pg-1.12.2/lib/sequel_pg.so"]
"\xE1\x80\x80"
$ ruby24 -I /data/code/sequel_pg/lib -I /data/code/external/ruby-pg/lib bin/sequel postgres:///?user=sequel_test -c 'p $LOADED_FEATURES.grep(/pg.*.so\z/); p DB[:s].get(:s)'
["/data/code/external/ruby-pg/lib/pg_ext.so", "/data/code/sequel_pg/lib/sequel_pg.so"]
"\u1000"

I would appreciate it if pg 1.2.1 could be released with this change.

This can be used by sequel_pg to get the encoding index.
Copy link
Owner

@ged ged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll push out a release ASAP, as my company is blocked on this too. ;)

@ged ged merged commit 6853309 into ged:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants