Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install in node 15.0.1 environment #65

Closed
1cgonza opened this issue Nov 9, 2020 · 16 comments
Closed

Unable to install in node 15.0.1 environment #65

1cgonza opened this issue Nov 9, 2020 · 16 comments

Comments

@1cgonza
Copy link

1cgonza commented Nov 9, 2020

Getting the following error when trying to install either client or server packages.

error wrtc@0.4.6: The engine "node" is incompatible with this module. Expected version "^8.11.2 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0". Got "15.0.1"

@yandeu
Copy link
Member

yandeu commented Nov 9, 2020

Downgrade your node version to v14.

@ouya99
Copy link

ouya99 commented Jan 21, 2021

@yandeu having same problem, could you maybe make it work for node 15.6 ?

node-webrtc/node-webrtc#658

suggests that the webrtc issue has been solved. Some people unfortunately (M1 macbook) can only use node15 :(

@yandeu
Copy link
Member

yandeu commented Jan 21, 2021

I just tried it on v15.6, but it failed.

@yandeu
Copy link
Member

yandeu commented Feb 3, 2021

Looks like version 2 will work on node v15.

@yandeu yandeu pinned this issue Feb 6, 2021
@yandeu
Copy link
Member

yandeu commented Feb 21, 2021

You can now try version 2 (dev)

 npm i @geckos.io/client@dev @geckos.io/server@dev

@ouya99
Copy link

ouya99 commented Feb 21, 2021

@yandeu tried it, it fixes the node issue, but your new dependency node-datachannel is not compiling on mac-arm64 (they only have pre-compiled arm-libs for win, linux)

After adding

set(OPENSSL_ROOT_DIR ${OPENSSL_ROOT_DIR} /opt/homebrew/opt/openssl@1.1/)
set(OPENSSL_CRYPTO_LIBRARY ${OPENSSL_ROOT_DIR}/lib/libcrypto.dylib CACHE FILEPATH "" FORCE)
set(OPENSSL_SSL_LIBRARY ${OPENSSL_ROOT_DIR}/lib/libssl.dylib CACHE FILEPATH "" FORCE)

to the CMakeLists (of the node-datachannel project) it compiles, so principally i can run v2 now , but would have to first compile node-datachannel, checkout geckos.io and adjust all paths to my own arm-64 lib.

Filed an issue murat-dogan/node-datachannel#28 to simplify installation via prebuilt

@ouya99
Copy link

ouya99 commented Feb 22, 2021

see murat-dogan/node-datachannel#28
solved it by changing OPENSSL location

@panuchka
Copy link

I have a similar problem with version 2 on Windows 10 machine. Installation apparently requires cmake and visual studio, is this true?

@ouya99
Copy link

ouya99 commented Feb 22, 2021

@panuchka yes it requires cmake. I am sure not if visual studio is required. I am on MacOS. But some c++ compiler should be installed. Check the build scripts of the dependencies to see what is required

@yandeu
Copy link
Member

yandeu commented Feb 22, 2021

Sure it still needs cmake on Windows 10 with node v15?

Looks like prebuilds for v15 were added today.

I added the latest node-datachannel version to the v2 branch and the build time reduced from 4m 56s to only 1m 39s, which is about the same time it always took for node v14 and v12

Anyways, I will publish v2.0.0-dev.2 in one hour or so. @panuchka please wait for installing cmake and try v2.0.0-dev.2 instead first.

@ouya99
Copy link

ouya99 commented Feb 22, 2021

I do not see prebuilds following your link.

on my machine (macOs) cmake is used to build it. But I am not 100% sure about Windows, Linux, but I did not find any prebuild files either, so I assume it uses cmake to build it locally, which murat also confirmed in my issue

@yandeu
Copy link
Member

yandeu commented Feb 22, 2021

I believe @murat-dogan is saying that his workflow does not generate and upload prebuilds for M1, since GitHub Actions do not support M1 yet. All other prebuilds are available. And since today also for Node.js v15.

On my Windows machine (Windows 10 with Node.js v14.15.3), v2.0.0-dev.1 works even though CMake is not installed:

ERR! OMG CMake is not installed. Install CMake.

@ouya99
Copy link

ouya99 commented Feb 22, 2021

it generates prebuilds for M1, simply by generating prebuild for mac. My M1-system can handle this, cause node15 is an arm-version and the toolchain too. My only mistake was having the wrong path for OPENSSL, with that even your v2-1 runs without any issue simply by typing "npm i"

@yandeu
Copy link
Member

yandeu commented Feb 22, 2021

@panuchka dev.2 is now on npm (npm i @geckos.io/server@2.0.0-dev.2).


it generates prebuilds for M1, simply by generating prebuild for mac. My M1-system can handle this, cause node15 is an arm-version and the toolchain too. My only mistake was having the wrong path for OPENSSL, with that even your v2-1 runs without any issue simply by typing "npm i"

I see. Well, I have nearly never used mac so I know absolutely nothing about it.

@panuchka
Copy link

Yeap, npm install went through this time! Thank you @yandeu ! ❤️

@yandeu
Copy link
Member

yandeu commented Feb 22, 2021

It seems, this issue can be closed?

Make sure you join the discussions.

@yandeu yandeu closed this as completed Feb 22, 2021
@yandeu yandeu unpinned this issue Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants