Send AttrOff when clearing the screen #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tcell v2.4, the following calls would reset the screen to its default color: 1. SetContent() to change the bg color to maroon. 2. Clear() 3. Show() In tcell v2.5, the behavior changed to clear the screen to the last-used style passed to SetContent. This happens because commit 62f5502 set the dirty flag to false for all cells, on the assumption that sending ti.Clear would clear the cells anyway. Unlike the drawCell calls triggered by the dirty flag, however, clearScreen does not send AttrOff. This causes the screen to clear to the last-used background color.
|
Thanks for resolving this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tcell v2.4, the following calls would reset the screen
to its default color:
In tcell v2.5, the behavior changed to clear the screen
to the last-used style passed to SetContent.
This happens because commit 62f5502 set the dirty flag
to false for all cells, on the assumption that sending
ti.Clear would clear the cells anyway. Unlike the drawCell
calls triggered by the dirty flag, however, clearScreen
does not send AttrOff. This causes the screen to clear
to the last-used background color.
Issue: #522