Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build of ros_gz_bridge fails after PR #394 #397

Closed
M1chaelM opened this issue May 23, 2023 · 4 comments
Closed

Build of ros_gz_bridge fails after PR #394 #397

M1chaelM opened this issue May 23, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@M1chaelM
Copy link

Environment

  • OS Version: 22.04
  • Source or binary build?
    source, humble branch. Last commits:
commit b64df31d2611ba4c51851f7270c3fb3096f94e9c (HEAD -> humble, tag: 0.244.11, origin/humble)
Author: Michael Carroll <michael@openrobotics.org>
Date:   Tue May 23 12:33:55 2023 -0500

    0.244.11
    
    Signed-off-by: Michael Carroll <michael@openrobotics.org>

commit 846323f299ee88ad6a01eb9ec140e10eb228169e
Author: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Date:   Mon May 22 20:31:05 2023 -0400

    Add actuator_msgs to humble bridge. (#394)
    
    Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

Description

  • Expected behavior: Running colcon build in the workspace should build all packages.
  • Actual behavior: The build fails with an error on ros_gz_bridge

Steps to reproduce

  1. Clone ros_gz into a fresh workspace.
  2. Run GZ_VERSION=garden colcon build --merge-install

Output

--- stderr: ros_gz_bridge
CMake Error at CMakeLists.txt:81 (find_package):
  By not providing "Findactuator_msgs.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "actuator_msgs", but CMake did not find one.

  Could not find a package configuration file provided by "actuator_msgs"
  with any of the following names:

    actuator_msgsConfig.cmake
    actuator_msgs-config.cmake

  Add the installation prefix of "actuator_msgs" to CMAKE_PREFIX_PATH or set
  "actuator_msgs_DIR" to a directory containing one of the above files.  If
  "actuator_msgs" provides a separate development package or SDK, be sure it
  has been installed.


gmake: *** [Makefile:1955: cmake_check_build_system] Error 1

Note

I think this is related to PR #394 because the change happened very recently. I noticed it because it broke our CI (osrf/vrx#658), so it seems to affect a fresh install.

@M1chaelM M1chaelM added the bug Something isn't working label May 23, 2023
@osrf-triage osrf-triage added this to Inbox in Core development May 23, 2023
@mjcarroll
Copy link
Collaborator

Yes, that PR introduced a new dependency on actuator_msgs. If you are installing via binary debians, this will be taken care of automatically.

If you are installing from source, you can get the dependency by installing ros-humble-actuator-msgs.

For robustness, I would recommend having a rosdep install --from-paths src as part of your source CI/installation process, which can catch added dependencies in package.xml for you.

@M1chaelM
Copy link
Author

Thanks for the speedy reply! Since this wasn't a bug I'll close it.

@M1chaelM
Copy link
Author

@mjcarroll Regarding your note about installing from binary debians--I would love to move to this but I thought they were not available for humble/garden. Is that correct?

@caguero
Copy link
Contributor

caguero commented May 27, 2023

See this issue for instructions about how to install debs for Humble/Garden:

gazebo-tooling/release-tools#895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants