From 771b767c879223e83333a0884ca00d87f16fff55 Mon Sep 17 00:00:00 2001 From: yuji38kwmt Date: Fri, 24 Sep 2021 20:27:28 +0900 Subject: [PATCH 1/3] encoding kwargs --- pyquery/pyquery.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pyquery/pyquery.py b/pyquery/pyquery.py index 13afbff..6e769d2 100644 --- a/pyquery/pyquery.py +++ b/pyquery/pyquery.py @@ -169,7 +169,10 @@ def __init__(self, *args, **kwargs): if kwargs: # specific case to get the dom if 'filename' in kwargs: - html = open(kwargs['filename']) + if 'encoding' in kwargs: + html = open(kwargs['filename'], encoding=kwargs['encoding') + else: + html = open(kwargs['filename']) elif 'url' in kwargs: url = kwargs.pop('url') if 'opener' in kwargs: From 3900c2986113e2ef2d8bf4aaae0b73681128250c Mon Sep 17 00:00:00 2001 From: yuji38kwmt Date: Fri, 24 Sep 2021 20:30:47 +0900 Subject: [PATCH 2/3] add encoding kwargs --- pyquery/pyquery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyquery/pyquery.py b/pyquery/pyquery.py index 6e769d2..cb813b0 100644 --- a/pyquery/pyquery.py +++ b/pyquery/pyquery.py @@ -170,7 +170,7 @@ def __init__(self, *args, **kwargs): # specific case to get the dom if 'filename' in kwargs: if 'encoding' in kwargs: - html = open(kwargs['filename'], encoding=kwargs['encoding') + html = open(kwargs['filename'], encoding=kwargs['encoding']) else: html = open(kwargs['filename']) elif 'url' in kwargs: From 4d372e7b2313d91918ea8a137e5e09434917cbdc Mon Sep 17 00:00:00 2001 From: yuji38kwmt Date: Mon, 27 Sep 2021 10:12:52 +0900 Subject: [PATCH 3/3] adopt reviewer's suggestion --- pyquery/pyquery.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pyquery/pyquery.py b/pyquery/pyquery.py index cb813b0..23d9c12 100644 --- a/pyquery/pyquery.py +++ b/pyquery/pyquery.py @@ -169,10 +169,8 @@ def __init__(self, *args, **kwargs): if kwargs: # specific case to get the dom if 'filename' in kwargs: - if 'encoding' in kwargs: - html = open(kwargs['filename'], encoding=kwargs['encoding']) - else: - html = open(kwargs['filename']) + html = open(kwargs['filename'], + encoding=kwargs.get('encoding')) elif 'url' in kwargs: url = kwargs.pop('url') if 'opener' in kwargs: