New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Value.IsXxx #253

Closed

gavv opened this issue Jan 28, 2023 · 2 comments · Fixed by #257

Assignees

Labels

feature good first issue help wanted important

Milestone

Owner

gavv commented Jan 28, 2023 •

edited

Value has several methods to cast value to specific type:

Object
Array
String
Number
Boolean

Each of them checks that the value has correct type and returns a new object for the value.

For each of these methods, we should add a counterpart method IsXxx (e.g. IsObject for Object) which just checks that the value has specific type, but does not create a new object, but instead returns the original (receiver) object.

New methods should have documentation comments and unit tests.

Related: #252

The text was updated successfully, but these errors were encountered:

gavv added feature help wanted good first issue important labels

Contributor

nhAnik commented Jan 29, 2023

Hi @gavv , can I work on this?

Owner Author

gavv commented Jan 29, 2023

You're welcome!

gavv assigned nhAnik

nhAnik mentioned this issue

Add Value.IsXxx #257

Merged

gavv closed this as completed in #257

gavv added this to the v2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment