Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive error raised (because of link-check@4.5.3 dependency of markdown-link-check) #84

Closed
oncleben31 opened this issue Dec 7, 2020 · 4 comments

Comments

@oncleben31
Copy link
Contributor

In my one of my repository I use this action (see workflow configuration

Since few days I have this error at each run:

ERROR: 1 dead links found!
[✖] https://github.com/oncleben31/home-assistant-config/workflows/Home%20Assistant%20configuration/badge.svg → Status: 404

If I clic the link in the action log, the expected image is displayed. I don't understand why the script detect a 404 error.

@philrz
Copy link

philrz commented Dec 7, 2020

I hit this as well and did a little more digging. It looks like a dependency changed, as tcort/markdown-link-check#142 describes other people running into issues with URLs containing %, and this project appears to depend on that tooling. So hopefully when that gets fixed we'll be fixed also.

@oncleben31
Copy link
Contributor Author

Perhaps the action code should pin the dependency version to avoid this type of regression

@gaurav-nelson gaurav-nelson changed the title False postive error raised False positive error raised (because of link-check@4.5.3 dependency of markdown-link-check) Dec 9, 2020
@NicolasMassart
Copy link

The issue is now fixed in the master branch of tcort/link-check, see tcort/link-check#34 and will be available in the next release. Thanks for your patience!

@gaurav-nelson
Copy link
Owner

Fixed in 1.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants