Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors output if path is not existent #52

Closed
koppor opened this issue Jun 14, 2020 · 7 comments · Fixed by #66
Closed

No errors output if path is not existent #52

koppor opened this issue Jun 14, 2020 · 7 comments · Fixed by #66

Comments

@koppor
Copy link

koppor commented Jun 14, 2020

The latest version of the action (updated version of #51) does not report errors any more:

grafik

Am I using it somehow wrong?

@gaurav-nelson
Copy link
Owner

@koppor Can you please check if it works with:

uses: gaurav-nelson/github-action-markdown-link-check@c44c6ba

I'll update the release tag if it does. Thank you.

@koppor
Copy link
Author

koppor commented Jun 16, 2020

Same result:

image

@gaurav-nelson
Copy link
Owner

gaurav-nelson commented Jun 16, 2020

@koppor Can you point me to the actual log? Usually results appear after those lines.

File extension bug is fixed in:

uses: gaurav-nelson/github-action-markdown-link-check@619e549

@koppor
Copy link
Author

koppor commented Jun 16, 2020

Here you go https://github.com/JabRef/jabref/pull/6542/checks?check_run_id=777818031.

Maybe the /docs is a wrong path. Need to investigate.

Maybe, || echo "ERROR: find terminated" should be added to the call to find.

Yeah, it really was the case. Fixed and now errors are output again: https://github.com/JabRef/jabref/pull/6542/checks?check_run_id=777883106

@koppor koppor changed the title No more errors output No errors output if path is not existent Jun 16, 2020
@gaurav-nelson
Copy link
Owner

@koppor this should be gone as well, Can you check?

@koppor
Copy link
Author

koppor commented Aug 18, 2020

Fails without error message:

grafik

See https://github.com/koppor/jabref/pull/458/checks?check_run_id=999417774 (from koppor/jabref#458) for details.

Think, this is OK.

@koppor koppor closed this as completed Aug 18, 2020
@gaurav-nelson
Copy link
Owner

I am reopening this one, looks like an easy fix, since I separated handling of files and folders, I can add a little check to fail with error if any specified file or folder doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants