Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives #50

Closed
JoshOrndorff opened this issue Jun 10, 2020 · 4 comments
Closed

False positives #50

JoshOrndorff opened this issue Jun 10, 2020 · 4 comments

Comments

@JoshOrndorff
Copy link

this CI job is failing becuase broken links are reported. In reality the links are working.

@JoshOrndorff
Copy link
Author

Update, the failures went away when I linked to https://substrate.dev instead of just substrate.dev

I'll leave the issue open because either:

  1. This is a bug and should be fixed
  2. This is the intended behaviour and should be documented

@koppor
Copy link

koppor commented Jun 14, 2020

I think, it is not easily possible to detect that substrace.dev is a proper link. https://substrate.dev is recognized as link.

GitHub Flavored Markdown only supports autolinking when the text starts with www.: https://github.github.com/gfm/#extended-www-autolink. See also your comment above. The text substrate.dev is not converted to a hyperlink.

Maybe, if links start with //, they could work. See https://stackoverflow.com/questions/4071117/uri-starting-with-two-slashes-how-do-they-behave for details.

@JoshOrndorff
Copy link
Author

Good to know about those autolinks. Thanks for showing me that.

But the links in my repo that were reported borken were not auto-linked. They were linked explicitly like [Some anchor text](substrate.dev/whatever).

I'm not stuck anymore, so close this if you like the way it works, but it seems like an issue to me.

@gaurav-nelson
Copy link
Owner

I think this issue deal more with how https://github.com/tcort/markdown-link-check handles the links. Glad that you found a way around to fix those links. I am closing this issue as it doesn't directly relate to the GitHub action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants