Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong filename output #40

Closed
koppor opened this issue May 27, 2020 · 5 comments
Closed

Wrong filename output #40

koppor opened this issue May 27, 2020 · 5 comments

Comments

@koppor
Copy link

koppor commented May 27, 2020

Output:

=========================> MARKDOWN LINK CHECK <=========================


FILE: docs/jpackage.md
[✖] https://github.com/YOUR_USERNAME/jabref → Status: 404


FILE: docs/adr/0004-use-mariadb-connector.md
[✖] https://github.com/JabRef/jabref/wiki/Translating-JabRef-Help → Status: 429
[✖] https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/formatter/bibtexfields/NormalizePagesFormatter.java → Status: 429

(Source: https://github.com/JabRef/jabref/pull/6524/checks?check_run_id=714600307)

The link with YOUR_USERNAME appears in a different file:

grafik

Same for the other block:

grafik

Is it possible to output the correct file name?

My config:

      - name: Run markdown-link-check
        uses: gaurav-nelson/github-action-markdown-link-check@v1
        with:
          use-quiet-mode: 'yes'
          use-verbose-mode: 'yes'
          config-file: 'mlc_config.json'
          folder-path: 'docs/'
@gaurav-nelson
Copy link
Owner

Thanks @koppor for reporting this.

Can you please turn off the quiet mode and check the full log once?

- name: Run markdown-link-check
        uses: gaurav-nelson/github-action-markdown-link-check@v1
        with:
          use-verbose-mode: 'yes'
          config-file: 'mlc_config.json'
          folder-path: 'docs/'

For verbose mode, the script parses the whole output and lists errors, it might have some logic issue. The full log will help me debug the issue.

koppor added a commit to JabRef/jabref that referenced this issue May 28, 2020
@koppor
Copy link
Author

koppor commented May 28, 2020

It's not as easy as I thought:

grafik

Did I configure something wrong?

      - name: Run markdown-link-check
        uses: gaurav-nelson/github-action-markdown-link-check@v1
        with:
          use-quiet-mode: 'no'
          use-verbose-mode: 'yes'
          config-file: 'mlc_config.json'
          folder-path: '/docs'

@JoshOrndorff
Copy link

I also encountered this here https://github.com/substrate-developer-hub/recipes/runs/743069911

The issue happens in quiet mode but goes away when I disable quiet mode.

@gaurav-nelson
Copy link
Owner

Thanks @koppor @JoshOrndorff

I've released version 1.0.3 to fix this. Also, updated the v1 tag to point to this release.

@JoshOrndorff
Copy link

Confirmed this is working for me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants