fix(gatsby): don't output file-loader assets to .cache #37284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: render-mode
tyhopp
approved these changes
Dec 19, 2022
pieh
added a commit
that referenced
this pull request
Dec 20, 2022
* fix(gatsby): don't output file-loader assets to .cache * use adjusted settings also for develop-html stage, as that one uses ROUTES_DIRECTORY too * update comment * some types for file-loader common options (cherry picked from commit 3cbad19)
pieh
added a commit
that referenced
this pull request
Dec 20, 2022
* fix(gatsby): don't output file-loader assets to .cache * use adjusted settings also for develop-html stage, as that one uses ROUTES_DIRECTORY too * update comment * some types for file-loader common options (cherry picked from commit 3cbad19)
pieh
added a commit
that referenced
this pull request
Dec 20, 2022
* fix(gatsby): don't output file-loader assets to .cache * use adjusted settings also for develop-html stage, as that one uses ROUTES_DIRECTORY too * update comment * some types for file-loader common options (cherry picked from commit 3cbad19) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh
added a commit
that referenced
this pull request
Dec 20, 2022
* fix(gatsby): don't output file-loader assets to .cache * use adjusted settings also for develop-html stage, as that one uses ROUTES_DIRECTORY too * update comment * some types for file-loader common options (cherry picked from commit 3cbad19) Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 26, 2023
This was referenced May 27, 2023
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
file-loader/url-loaderemits duplicate to seperate locations:public/static:.cache/page-ssr/routes/static:public/staticis where we want assets to go, as those are the assets that will be uploaded. This outpath is used duringbuild-javascriptordevelopstage..cache/page-ssr/routes/staticis result of using output settings forbuild-html/develop-html(gatsby/packages/gatsby/src/utils/webpack.config.js
Lines 144 to 149 in 770748d
This PR adjust
url-loaderandfile-loaderforbuild-htmlanddevelop-htmlstages to output topublicwhile preserving what urls are generated.Alternatively there is option to skip asset emission ( https://v4.webpack.js.org/loaders/file-loader/#emitfile ), but I figured that changing output location could be beneficial in case there might not be full overlap between html gen bundle and browser bundle. Skipping emission would not result in regression versus what we have now, but adjusting the outputpath might fix some possible edge cases we might have today.
Documentation
Related Issues