Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): Normalize filename for correct hashing #37262

Merged
merged 2 commits into from Dec 14, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Dec 14, 2022

Description

The state.filename from babel isn't normalized, the filename coming from preprocessSource is. So there was a mismatch between the hashes on Windows. This fixes it by also normalizing was comes from babel.

Related Issues

#37251 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 14, 2022
@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 14, 2022
@LekoArts LekoArts added this to To cherry-pick in V5 Release hotfixes via automation Dec 14, 2022
@marvinjude marvinjude merged commit 397fa3f into master Dec 14, 2022
@marvinjude marvinjude deleted the image-windows-annoyance branch December 14, 2022 14:46
marvinjude pushed a commit that referenced this pull request Dec 14, 2022
)

* initial

* add peace of mind

(cherry picked from commit 397fa3f)
@marvinjude marvinjude moved this from To cherry-pick to Backport PR opened in V5 Release hotfixes Dec 14, 2022
marvinjude pushed a commit that referenced this pull request Dec 14, 2022
) (#37263)

* initial

* add peace of mind

(cherry picked from commit 397fa3f)

Co-authored-by: Lennart <lekoarts@gmail.com>
@marvinjude marvinjude moved this from Backport PR opened to Backported in V5 Release hotfixes Dec 14, 2022
@marvinjude marvinjude moved this from Backported to Published in V5 Release hotfixes Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants