Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): use file:// protocol when importing gatsby-config/node #37257

Merged
merged 5 commits into from Dec 14, 2022
Merged

fix(gatsby): use file:// protocol when importing gatsby-config/node #37257

merged 5 commits into from Dec 14, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Dec 14, 2022 •
edited by LekoArts

Description

Fixes for errors on Windows after #37068:

Error: Only URLs with a scheme in: file, data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received 
  protocol 'c:'

Related Issues

Fixes #37251
nodejs/node#31710

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 14, 2022
@pieh pieh added type: bug An issue or pull request relating to a bug in Gatsby topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 14, 2022
@pieh pieh force-pushed the fix/use-file-url-when-importing branch from 7eb4573 to 09a896b Compare December 14, 2022 09:52
@pieh pieh mentioned this pull request Dec 14, 2022
Closed
2 tasks
@pieh pieh marked this pull request as ready for review December 14, 2022 10:26
@LekoArts LekoArts added this to To cherry-pick in V5 Release hotfixes via automation Dec 14, 2022
@pieh pieh merged commit e0ea47c into master Dec 14, 2022
@pieh pieh deleted the fix/use-file-url-when-importing branch December 14, 2022 10:40
@gatsbybot gatsbybot mentioned this pull request Dec 14, 2022
Merged
marvinjude pushed a commit that referenced this pull request Dec 14, 2022
@pieh @marvinjude
fix(gatsby): use file:// protocol when importing gatsby-config/node (#…
0f1a5d7 
…37257)

* fix(gatsby): use file:// protocol when importing gatsby-config/node

* Revert "fix(gatsby): use file:// protocol when importing gatsby-config/node"

This reverts commit 74d4090.

* different solution?

* only file://ify when importing

* update mock

(cherry picked from commit e0ea47c)
marvinjude pushed a commit that referenced this pull request Dec 14, 2022
@ViCo0TeCH @pieh
fix(gatsby): use file:// protocol when importing gatsby-config/node (#…
a283319 
…37257) (#37260)

* fix(gatsby): use file:// protocol when importing gatsby-config/node

* Revert "fix(gatsby): use file:// protocol when importing gatsby-config/node"

This reverts commit 74d4090.

* different solution?

* only file://ify when importing

* update mock

(cherry picked from commit e0ea47c)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@LekoArts LekoArts moved this from To cherry-pick to Published in V5 Release hotfixes Dec 14, 2022
@LekoArts LekoArts moved this from Published to Backported in V5 Release hotfixes Dec 14, 2022
@LekoArts LekoArts moved this from Backported to Published in V5 Release hotfixes Dec 14, 2022
@LekoArts LekoArts added this to the ESM in Gatsby files milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) type: bug An issue or pull request relating to a bug in Gatsby
Projects
V5 Release hotfixes
Published
Milestone
ESM in Gatsby files
Development

Successfully merging this pull request may close these issues.

Gatsby 5.3 - "On Windows, absolute paths must be valid file://"
2 participants
@pieh @LekoArts