feat(gatsby-worker): Show original stack trace #37206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with process.exit
…ence ipc send errors if worker is disconnected
…nsure-sudden-worker-exit-doesnt-loose-messages
LekoArts
added
the
topic: core
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
tyhopp
approved these changes
Dec 8, 2022
LekoArts
deleted the
fix/gatsby-worker/ensure-sudden-worker-exit-doesnt-loose-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When our workers fail a task, they'll often error with a single line message with no context. One of our top error messages across all versions is "Building static HTML failed".
Or it says Error: Worker exited before finishing task. With this PR the original error thrown in the error should be surfaced at leat.
There is polishing to be done in follow-up work, but this is a good start to begin with.
Related Issues
Fixes #36947
[ch58027]