Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): ESM in gatsby-config.mjs and gatsby-node.mjs #37068

Merged
merged 37 commits into from Dec 8, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Nov 21, 2022

Description

Add support for ESM in gatsby-config.mjs and gatsby-node.mjs files.

Documentation

To be added in a future PR

Related Issues

[sc-58291]
[sc-58293]

@tyhopp tyhopp added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Nov 21, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 21, 2022
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 21, 2022
@tyhopp tyhopp added this to the ESM in Gatsby files milestone Nov 21, 2022
@tyhopp tyhopp changed the title feat(gatsby): ESM in gatsby files feat(gatsby): ESM in gatsby files proof of concept Nov 21, 2022
@tyhopp tyhopp changed the title feat(gatsby): ESM in gatsby files proof of concept feat(gatsby): ESM in gatsby files Nov 21, 2022
@LekoArts LekoArts changed the title feat(gatsby): ESM in gatsby files feat(gatsby): ESM with gatsby-config/-node.mjs Nov 21, 2022
@tyhopp tyhopp changed the title feat(gatsby): ESM with gatsby-config/-node.mjs feat(gatsby): ESM in gatsby-config.mjs and gatsby-node.mjs Nov 22, 2022
marvinjude and others added 9 commits November 29, 2022 09:40
* Adjust resolve-module-exports to use single await import

* Fix load-plugins tests

* Import plugins instead of require them

* Remove todo, api-runner-node refactor should be revisited

* Make jobs manager tests pass again

* Do not gitignore jobs manager fixture in node_modules

* Prefer default to handle case of await import cjs module

* Resolve js file path without fs module

* Do not remove default property

* Fix case where compiled file paths include file extensions already
@tyhopp tyhopp marked this pull request as ready for review December 6, 2022 09:20
@pieh pieh merged commit 99c5688 into master Dec 8, 2022
@pieh pieh deleted the feat/esm-in-gatsby-files branch December 8, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants