New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): ESM in gatsby-config.mjs and gatsby-node.mjs #37068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyhopp
added
the
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
label
Nov 21, 2022
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 21, 2022
tyhopp
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 21, 2022
tyhopp
changed the title
feat(gatsby): ESM in gatsby files
feat(gatsby): ESM in gatsby files proof of concept
Nov 21, 2022
tyhopp
changed the title
feat(gatsby): ESM in gatsby files proof of concept
feat(gatsby): ESM in gatsby files
Nov 21, 2022
LekoArts
changed the title
feat(gatsby): ESM in gatsby files
feat(gatsby): ESM with gatsby-config/-node.mjs
Nov 21, 2022
tyhopp
changed the title
feat(gatsby): ESM with gatsby-config/-node.mjs
feat(gatsby): ESM in gatsby-config.mjs and gatsby-node.mjs
Nov 22, 2022
…ses (#37098) Co-authored-by: Lennart <lekoarts@gmail.com>
LekoArts
reviewed
Nov 29, 2022
* Adjust resolve-module-exports to use single await import * Fix load-plugins tests * Import plugins instead of require them * Remove todo, api-runner-node refactor should be revisited * Make jobs manager tests pass again * Do not gitignore jobs manager fixture in node_modules * Prefer default to handle case of await import cjs module * Resolve js file path without fs module * Do not remove default property * Fix case where compiled file paths include file extensions already
pieh
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for ESM in
gatsby-config.mjs
andgatsby-node.mjs
files.Documentation
To be added in a future PR
Related Issues
[sc-58291]
[sc-58293]