Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): Make onLoad callback work on first load #36375

Merged
merged 1 commit into from Aug 12, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Aug 12, 2022

Description

Fixes onLoad callback execution on first load. Also moves onStartLoad in this scenario to execute at the right time (not in the load event listener callback).

Documentation

N/A

Related Issues

Fixes #36373

[sc-54332]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 12, 2022
@tyhopp tyhopp added topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 12, 2022
@LekoArts LekoArts requested a review from wardpeet August 12, 2022 08:32
@marvinjude marvinjude merged commit 3dfc1ec into master Aug 12, 2022
@marvinjude marvinjude deleted the fix-gatsby-plugin-image-on-load branch August 12, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: plugins Related to plugin system, themes & catch-all for plugins that don't have a label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GatsbyImage's "onLoad" prop does not always trigger when image is not cached
3 participants