Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused deps #36368

Merged
merged 2 commits into from Aug 12, 2022
Merged

chore: Remove unused deps #36368

merged 2 commits into from Aug 12, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Aug 11, 2022

Description

Removes unused dependencies from packages

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 11, 2022
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 12, 2022
@LekoArts LekoArts marked this pull request as ready for review August 12, 2022 04:42
@@ -17,15 +17,13 @@
],
"devDependencies": {
"@ascorbic/worker-threads-shim": "^1.0.0",
"@babel/runtime": "^7.15.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also listed as a dependency, can we remove that too or is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in #32954, I just want to leave it for now and we can revisit it later. Didn't want to break anything

@LekoArts LekoArts merged commit 8bad1a7 into master Aug 12, 2022
@LekoArts LekoArts deleted the remove-unused-deps branch August 12, 2022 05:29
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants