Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): use host param for express again #36186

Merged
merged 1 commit into from Jul 20, 2022
Merged

Conversation

wardpeet
Copy link
Contributor

Description

Due removing the develop proxy, I didn't notice that we hardcoded localhost. We now use the host option again

Documentation

Related Issues

Fixes #36177

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 20, 2022
@wardpeet wardpeet added type: bug An issue or pull request relating to a bug in Gatsby topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 20, 2022
@wardpeet wardpeet added this to To cherry-pick in V4 Release hotfixes via automation Jul 20, 2022
@LekoArts LekoArts added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 20, 2022
@gatsbybot gatsbybot merged commit f35fda7 into master Jul 20, 2022
@gatsbybot gatsbybot deleted the fix/host-param branch July 20, 2022 07:57
LekoArts pushed a commit that referenced this pull request Jul 20, 2022
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Jul 20, 2022
LekoArts pushed a commit that referenced this pull request Jul 20, 2022
Co-authored-by: Ward Peeters <ward@coding-tech.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in V4 Release hotfixes Jul 20, 2022
@LekoArts LekoArts moved this from Backported to Published in V4 Release hotfixes Jul 20, 2022
@LekoArts
Copy link
Contributor

Fixed in gatsby@4.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) type: bug An issue or pull request relating to a bug in Gatsby
Projects
Development

Successfully merging this pull request may close these issues.

gatsby develop -H 0.0.0.0 not working
3 participants