Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Wrap Head with <Location> #36160

Merged
merged 3 commits into from Jul 19, 2022
Merged

fix(gatsby): Wrap Head with <Location> #36160

merged 3 commits into from Jul 19, 2022

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Jul 18, 2022 •
edited

Description

Wrap Head with LocationContext.Provider to allow hooks or components that depends on LocationContext.Provider to work ( e.g useLocation)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 18, 2022
@marvinjude marvinjude changed the title fix(gatsby): Wrap Head component with <Location> fix(gatsby): Wrap Head with <Location> Jul 18, 2022
@marvinjude marvinjude added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 18, 2022
@LekoArts LekoArts added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed type: bug An issue or pull request relating to a bug in Gatsby labels Jul 19, 2022
@LekoArts LekoArts added this to the Metadata Management milestone Jul 19, 2022
@LekoArts LekoArts merged commit c3c6a5b into master Jul 19, 2022
@LekoArts LekoArts deleted the head-api-location-fix branch July 19, 2022 04:25
@gatsbybot gatsbybot mentioned this pull request Jul 19, 2022
Merged
LekoArts pushed a commit that referenced this pull request Jul 19, 2022
@marvinjude @LekoArts
fix(gatsby): Wrap Head with <Location> (#36160)
1de8b92 
(cherry picked from commit c3c6a5b)
@LekoArts LekoArts added this to Backport PR opened in Release candidate Jul 19, 2022
LekoArts pushed a commit that referenced this pull request Jul 19, 2022
@ViCo0TeCH @marvinjude
fix(gatsby): Wrap Head with <Location> (#36160) (#36165)
19c9c0b 
Co-authored-by: Jude Agboola <marvinjudehk@gmail.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in Release candidate Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
No open projects
Release candidate
Backported
Milestone
Metadata Management
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marvinjude @LekoArts