Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): Improvements to GraphQL TypeScript Generation #35581

Merged
merged 10 commits into from May 5, 2022
Merged

feat(gatsby): Improvements to GraphQL TypeScript Generation #35581

merged 10 commits into from May 5, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented May 3, 2022 •
edited

Description

Follow-up to #35487 - The goal here is to get this feature into a GA-Ready state.

TODOs:

  • Proper E2E tests that also test the hot-reloading behavior and correct contents
  • Skip creating graphql.config.json if it already exists
  • Listen to SET_SCHEMA and SET_GRAPHQL_DEFINITIONS and only then run the activites
  • Add pluckConfig to only look at graphql() function from Gatsby

Documentation

Will be added here: #35584

Related Issues

RFC: #35420

[ch49658]
[ch49877]
[ch50092]

@LekoArts LekoArts added the topic: GraphQL Related to Gatsby's GraphQL layer label May 3, 2022
@LekoArts LekoArts added this to the GraphQL TypeScript Generation milestone May 3, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2022
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2022
@LekoArts LekoArts marked this pull request as ready for review May 4, 2022 14:20
pieh
pieh approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LekoArts LekoArts merged commit 966aca8 into master May 5, 2022
@LekoArts LekoArts deleted the typegen-one branch May 5, 2022 09:15
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@MaxMood96 MaxMood96 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@kaocher82 kaocher82 mentioned this pull request May 10, 2022
Open
@Rutam21 Rutam21 mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 10, 2022
Open
@0xSebin 0xSebin mentioned this pull request May 10, 2022
Open
@saurabharch saurabharch mentioned this pull request May 10, 2022
Open
This was referenced May 10, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
This was referenced Nov 29, 2022
Open
Open
@samq-ws samq-ws mentioned this pull request Nov 29, 2022
Open
This was referenced Nov 29, 2022
Open
Open
Open
This was referenced Feb 28, 2023
Open
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 1, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Mar 16, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2023
Open
@saurabharch saurabharch mentioned this pull request Mar 21, 2023
Open
This was referenced Mar 28, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Apr 19, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2023
Open
@monizb monizb mentioned this pull request Apr 20, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 4, 2023
Open
@kaocher82 kaocher82 mentioned this pull request May 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 23, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jun 16, 2023
Open
@nidhi42 nidhi42 mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Milestone
GraphQL Typegen
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LekoArts @pieh