Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-utils): enable tracedsvg #35328

Merged
merged 3 commits into from Apr 20, 2022
Merged

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Apr 2, 2022

Description

Enable traced SVG for image cdn and convert all implementations to our own @gatsbyjs/potrace with GNU 3 License to be compatible with MIT.

I've updated all potrace usage

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 2, 2022
@wardpeet wardpeet changed the title feat/image cdn tracedsvg feat(gatsby-plugin-utils): enable tracedsvg Apr 2, 2022
@wardpeet wardpeet changed the base branch from master to veryspry/image-cdn-long-filename April 2, 2022 22:19
@wardpeet wardpeet added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 2, 2022
Base automatically changed from veryspry/image-cdn-long-filename to master April 6, 2022 13:51
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :) What benefit does @gatsby/potrace give us over the original package?

@wahidshafique
Copy link
Contributor

Very nice! :) What benefit does @gatsby/potrace give us over the original package?

Just pitching here in support of this, our team is blocked heavily since the original package has the viral GPL license. Our clients can't move forward without assurance that all code we use is compliant with their particular license agreements

@wardpeet
Copy link
Contributor Author

wardpeet commented Apr 19, 2022

Just pitching here in support of this, our team is blocked heavily since the original package has the viral GPL license. Our clients can't move forward without assurance that all code we use is compliant with their particular license agreements

I upgraded the license to GPL v3 (which is allowed by their License) and GPL v3 is compatible with MIT

@TylerBarnes
Copy link
Contributor

Amazing, I was wondering how that would work 👍

@wardpeet wardpeet merged commit a246011 into master Apr 20, 2022
@wardpeet wardpeet deleted the feat/image-cdn-tracedsvg branch April 20, 2022 21:10
@muescha
Copy link
Contributor

muescha commented Apr 26, 2022

I upgraded the license to GPL v3 (which is allowed by their License) and GPL v3 is compatible with MIT

in Readme there is still noted v2:

The GNU General Public License version 2 (GPLv2).

// PR: gatsbyjs/node-potrace#1

@tony
Copy link

tony commented Apr 30, 2022

GPL v3 is compatible with MIT

(I assume this means LGPLv3, per this thread and https://github.com/gatsbyjs/node-potrace/blob/f182e9e/LICENSE)

Lesser GPL isn't interoperable as it looks. The wording can be muddy as it wasn't written with scripting languages and package systems in mind.

Diagram on license compatibility

image
image

source: https://en.wikipedia.org/wiki/License_compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants