Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks #35246

Merged
merged 3 commits into from Mar 29, 2022
Merged

fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks #35246

merged 3 commits into from Mar 29, 2022

Conversation

wardpeet
Copy link
Contributor

Description

I've found some windows quirks during testing image-cdn.

I've added tests and fixed them.

  1. When excludeDigest was given and the file already got requested, we could end up with a / path and a \ path on windows which would not copy if it's inside public folder
  2. trace-svg with long urls could end up with .. which is not a proper filename on windows.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 29, 2022
@wardpeet wardpeet added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 29, 2022
@wardpeet wardpeet changed the title fix: windows quirks fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks Mar 29, 2022
@wardpeet wardpeet added this to To cherry-pick in V4 Release hotfixes via automation Mar 29, 2022
@wardpeet @pieh
Update packages/gatsby-plugin-sharp/src/trace-svg.js
d8a77b8 
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
@pieh pieh merged commit 392d6bc into master Mar 29, 2022
@pieh pieh deleted the fix/windows-quirks branch March 29, 2022 18:33
@gatsbybot gatsbybot mentioned this pull request Mar 31, 2022
Merged
marvinjude pushed a commit that referenced this pull request Mar 31, 2022
@wardpeet @marvinjude
fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks (#35246)
6257f75 
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 392d6bc)
@marvinjude marvinjude moved this from To cherry-pick to Backport PR opened in V4 Release hotfixes Mar 31, 2022
marvinjude pushed a commit that referenced this pull request Mar 31, 2022
@ViCo0TeCH @wardpeet
fix(gatsby-plugin-sharp,gatsby-core-utils): windows quirks (#35246) (#…
a527891 
…35268)

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 392d6bc)

Co-authored-by: Ward Peeters <ward@coding-tech.com>
@marvinjude marvinjude moved this from Backport PR opened to Backported in V4 Release hotfixes Mar 31, 2022
@marvinjude
Copy link
Contributor

Published in gatsby-plugin-sharp@4.11.1, gatsby-core-utils@3.11.1

@marvinjude marvinjude moved this from Backported to Published in V4 Release hotfixes Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
V4 Release hotfixes
Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wardpeet @marvinjude @pieh