Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-sharp): Upgrade probe-image-size to fix memory leak warning #35009

Merged
merged 3 commits into from Mar 7, 2022

Conversation

jonohewitt
Copy link
Contributor

Description

Upgrades probe-image-size to ^7.0.0 to fix the MaxListenersExceededWarning console error caused by versions prior to nodeca/probe-image-size@a6da059

Thanks to @hendra-go for discovering the cause of the issue.

Related Issues

Fixes #34795

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2022
@LekoArts
Copy link
Contributor

LekoArts commented Mar 2, 2022

@jonohewitt Hi! You'll need to run yarn in the monorepo to update the yarn.lock file. Also, I recommend not working on the master branch but off of another dedicated branch (in the future).

@jonohewitt
Copy link
Contributor Author

Hi @LekoArts! Sorry about that - I've pushed another commit updating the yarn.lock and will remember to create a new branch next time.

@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 7, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts changed the title fix(gatsby-plugin-sharp): Upgrade probe-image-size to fix memory leak warning fix(gatsby-plugin-sharp): Upgrade probe-image-size to fix memory leak warning Mar 7, 2022
@LekoArts LekoArts merged commit f98c9ba into gatsbyjs:master Mar 7, 2022
@ayushayagatsby
Copy link

Hi! I am occurring in this error as well for an existing project which runs on npm. How could I fix this?
I'm quite new to this, so sorry if this is a silly question.

@jonohewitt
Copy link
Contributor Author

Hi @ayushayagatsby, it looks like this fix was included in gatsby releases since 4.10 so you would just have to update gatsby to a version since then.

Docs for updating Gatsby
Docs for migrating from v3 to v4 if you're still on v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MaxListenersExceededWarning errors with gatsby-plugin-image StaticImage with placeholder
4 participants