Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starter): Add minimal Typescript starter #34688

Merged
merged 8 commits into from
Feb 7, 2022
Merged

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Feb 2, 2022

Description

Adds minimal TypeScript Starter gatsby-starter-minimal-ts

see - https://github.com/gatsbyjs/gatsby-starter-minimal

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 2, 2022
@marvinjude marvinjude removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 3, 2022
@LekoArts
Copy link
Contributor

LekoArts commented Feb 3, 2022

We don't want to use the canary yet, the starter should only use things that are stable and tested. Initially I wanted this also in there but we shouldn't block the CLI work by this.

@marvinjude
Copy link
Contributor Author

Yup same thoughts too. Wanted to put it up temporarily.. Ideally the tests shouldn't be failing right?

@LekoArts
Copy link
Contributor

LekoArts commented Feb 3, 2022

It uses 4.6.1 and not the canary I think.

It should have a config file. Just a JavaScript one for now.

@marvinjude marvinjude changed the title WIP: chore(starter): Add minimal Typescript starter chore(starter): Add minimal Typescript starter Feb 4, 2022
@marvinjude marvinjude marked this pull request as ready for review February 4, 2022 11:19
@LekoArts
Copy link
Contributor

LekoArts commented Feb 4, 2022

We'll need to add gatsby-starter-minimal-ts here, too: https://github.com/gatsbyjs/gatsby/blob/master/scripts/publish-starters.sh#L40

Need to google how you write a || in bash :D

@LekoArts
Copy link
Contributor

LekoArts commented Feb 4, 2022

Heh, did mean to commit this to the PR, not on master: 130d1dc

But yeah, it's in there now 😅

@LekoArts LekoArts merged commit 72b3586 into master Feb 7, 2022
@LekoArts LekoArts deleted the add-minimal-ts-starter branch February 7, 2022 12:06
wardpeet pushed a commit to wardpeet/gatsby that referenced this pull request Feb 8, 2022
Co-authored-by: LekoArts <lekoarts@gmail.com>
@LekoArts LekoArts added this to the TypeScript Improvements milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants