Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update "Debugging HTML builds" to include getServerData #34631

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

xaviemirmon
Copy link
Contributor

…nd-runtime-ssr.md

Description

Updating HTML build docs to include information about about "browser globals" during "runtime SSR"

Documentation

Related Issues

Fixes #34519

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 31, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the filename and title as is :)

We'll want to only edit the first paragraph a little bit, something like this:

Errors while building static HTML files (the build-time React SSR process) or while using `getServerData` (the [runtime SSR](/docs/reference/rendering-options/server-side-rendering/) process) generally happen for one of the following reasons

@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 31, 2022
@marvinjude marvinjude added the status: awaiting author response Additional information has been requested from the author label Feb 1, 2022
@LekoArts LekoArts changed the title Update and rename debugging-html-builds.md to debugging-html-builds-a… chore(docs): Update "Debugging HTML builds" to include getServerData Feb 7, 2022
@LekoArts LekoArts removed the status: awaiting author response Additional information has been requested from the author label Feb 7, 2022
@LekoArts LekoArts merged commit 0c04ce0 into gatsbyjs:master Feb 7, 2022
wardpeet pushed a commit to wardpeet/gatsby that referenced this pull request Feb 8, 2022
@xaviemirmon xaviemirmon deleted the patch-1 branch February 10, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New SSR Render Mode Documentation Unclear
3 participants