Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-cli): make --inspect-brk work #34242

Merged
merged 2 commits into from Dec 14, 2021
Merged

fix(gatsby-cli): make --inspect-brk work #34242

merged 2 commits into from Dec 14, 2021

Conversation

iChenLei
Copy link
Contributor

@iChenLei iChenLei commented Dec 11, 2021 •
edited by LekoArts

Description

Follow gatsby official debug guide ->
https://www.gatsbyjs.com/docs/debugging-the-build-process/#running-gatsby-with-the-inspect-flag

We know we can use --inspect or --inspect-brk via this PR #24693 .

2021-12-11 21 11 24

⚠️ --inspect-brk not work as expected

Documentation

N/A

Related Issues

Related to #24693 and #26379

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 11, 2021
@iChenLei
Copy link
Contributor Author

No unit or e2e test ? Sorry , sirs, I really don't know how to test cli, this case we need test user create a node debugger at custom port.

gatsby develop --inspect-brk=3600

// Need check 3600 port create a debugger
Debugger listening on ws://127.0.0.1:3600/294ab16e-8c7b-4760-9b1f-a8d78180ea68

@iChenLei
Copy link
Contributor Author

iChenLei commented Dec 11, 2021 •
edited

This PR not fix #26379, that's another issue. Support --inspect=[host:port]and --inspect-brk=[host:port] need refact all relative code.

wardpeet
wardpeet approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👏

@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 14, 2021
@LekoArts LekoArts changed the title fix(gatsby-cli): make --inspect-brk work fix(gatsby-cli): make --inspect-brk work Dec 14, 2021
@LekoArts LekoArts merged commit 9b9419c into gatsbyjs:master Dec 14, 2021
@iChenLei iChenLei deleted the fix-inspect-port branch December 14, 2021 07:13
@pieh pieh added this to To cherry-pick in Release candidate via automation Dec 14, 2021
@gatsbybot gatsbybot mentioned this pull request Dec 14, 2021
Merged
LekoArts pushed a commit that referenced this pull request Dec 14, 2021
@iChenLei @LekoArts
fix(gatsby-cli): make --inspect-brk work (#34242)
143a166 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
(cherry picked from commit 9b9419c)
LekoArts pushed a commit that referenced this pull request Dec 14, 2021
@wardpeet @iChenLei
fix(gatsby-cli): make --inspect-brk work (#34242) (#34254)
7a432a8 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: Lei Chen <chenleicoder@foxmail.com>
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in Release candidate Dec 14, 2021
@LekoArts LekoArts moved this from Backport PR opened to Backported in Release candidate Dec 14, 2021
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@ViCo0TeCH @wardpeet
fix(gatsby-cli): make --inspect-brk work (gatsbyjs#34242)
ca8c005 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
@kaocher82 kaocher82 mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
topic: cli Related to the Gatsby CLI
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iChenLei @wardpeet @LekoArts