Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-emotion): Use correct babel preset with jsxRuntime #34085

Merged
merged 5 commits into from Dec 8, 2021
Merged

feat(gatsby-plugin-emotion): Use correct babel preset with jsxRuntime #34085

merged 5 commits into from Dec 8, 2021

Conversation

iChenLei
Copy link
Contributor

@iChenLei iChenLei commented Nov 26, 2021 •
edited

Description

Detect user's gatsby config of jsxRuntime and set right babel config for emotion

Documentation

N/A

Related Issues

Fixes #33936

cc @wardpeet

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 26, 2021
@LekoArts LekoArts added topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 7, 2021
@marvinjude marvinjude changed the title feat: set right babel config for emotion when use jsxRuntime feat(gatsby-plugin-emotion): set right babel config for emotion when using jsxRuntime Dec 8, 2021
marvinjude
marvinjude approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@marvinjude marvinjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@iChenLei
Copy link
Contributor Author

iChenLei commented Dec 8, 2021

Unfortunately, ci failed, what't wrong with this PR ?

@LekoArts LekoArts changed the title feat(gatsby-plugin-emotion): set right babel config for emotion when using jsxRuntime feat(gatsby-plugin-emotion): Use correct babel preset with jsxRuntime Dec 8, 2021
@LekoArts LekoArts merged commit 01d7a79 into gatsbyjs:master Dec 8, 2021
@iChenLei iChenLei deleted the emotion-jsxruntime branch December 8, 2021 12:21
@kaocher82 kaocher82 mentioned this pull request Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinjude marvinjude marvinjude approved these changes

Assignees
No one assigned
Labels
topic: plugins-styling Relates to the styling (e.g. CSS-in-JS, SASS, PostCSS)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-emotion] Avoid using @emotion/babel-preset-css-prop when jsxRuntime set to automatic
3 participants
@iChenLei @marvinjude @LekoArts