Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): don't log FAST_DEV message for each worker #32961

Merged
merged 1 commit into from Aug 30, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Aug 30, 2021

Description

FAST_DEV flag right now results in multiple copies of same logs (one for each worker), due to transitional import in

import {
IGroupedQueryIds,
runPageQueries,
runStaticQueries,
} from "../../../services"
and fact that we handle env var at import time.

This is absolutely not ideal, but we also can't easily move the code from import time path as it might be handled too late otherwise.

Related Issues

[ch35984]
#32389 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 30, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 30, 2021
@LekoArts LekoArts added the topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) label Aug 30, 2021
@pieh pieh merged commit e547dc3 into master Aug 30, 2021
@pieh pieh deleted the fix/pqr/fast-dev-logs-per-worker branch August 30, 2021 13:03
@LekoArts LekoArts added this to To cherry-pick in Release candidate via automation Aug 31, 2021
vladar pushed a commit that referenced this pull request Aug 31, 2021
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Aug 31, 2021
vladar added a commit that referenced this pull request Aug 31, 2021
)

* fix(gatsby): don't log FAST_DEV message for each worker (#32961)

(cherry picked from commit e547dc3)

* trigger ci

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants