Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Set staticQueryResultHash to new hash #32949

Merged
merged 2 commits into from Aug 30, 2021
Merged

fix(gatsby): Set staticQueryResultHash to new hash #32949

merged 2 commits into from Aug 30, 2021

Conversation

herecydev
Copy link
Contributor

Description

Sets the tracked hash to the new hash if the query was dirty

Related Issues

Fixes #25928

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 28, 2021
pieh
pieh approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this change make total sense. Thank you for the fix!

@pieh pieh merged commit 88e1559 into gatsbyjs:master Aug 30, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 30, 2021
@pieh pieh added this to To cherry-pick in Release candidate via automation Aug 30, 2021
@KyleAMathews
Copy link
Contributor

Ooo nice find! This definitely solves some of the "static query cannot be found" issues.

@herecydev herecydev deleted the topic/staticQueryHash branch August 30, 2021 15:08
@gatsbybot gatsbybot mentioned this pull request Aug 31, 2021
Merged
vladar pushed a commit that referenced this pull request Aug 31, 2021
@herecydev @vladar
fix(gatsby): set staticQueryResultHash to new hash on data change (#3…
9443630 
…2949)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 88e1559)
@vladar vladar moved this from To cherry-pick to Backport PR opened in Release candidate Aug 31, 2021
vladar pushed a commit that referenced this pull request Aug 31, 2021
@herecydev
fix(gatsby): set staticQueryResultHash to new hash on data change (#3…
f936c93 
…2949) (#32966)

Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
(cherry picked from commit 88e1559)

Co-authored-by: Dan Kirkham <herecy@live.co.uk>
@vladar vladar moved this from Backport PR opened to Backported in Release candidate Aug 31, 2021
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 23, 2024
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Mar 23, 2024
Open
This was referenced Mar 23, 2024
Open
Open
This was referenced Mar 23, 2024
Open
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Mar 23, 2024
Open
This was referenced Mar 23, 2024
Open
Open
Open
Open
Open
This was referenced Mar 23, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional page builds not working with static queries
3 participants
@herecydev @KyleAMathews @pieh