Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby): display message about unfit flags found in config #32394

Merged
merged 4 commits into from Jul 19, 2021
Merged

feat(gatsby): display message about unfit flags found in config #32394

merged 4 commits into from Jul 19, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jul 16, 2021 •
edited

Description

There are situations when some feature flag is set in the config but it is not available in a given environment. For example: LMDB_STORE is only available with Node 14.10+ but if you set it in gatsby-config.js and try running a build with Node 12 - it will silently ignore the flag and run with the in-memory store. Which may lead to confusion.

This PR adds a warning to notify you when some flag is set but has no effect. Here is how it looks in CLI output now:

image

[ch32258]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 16, 2021
@vladar vladar added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 16, 2021
@vladar vladar added this to To cherry-pick in Release candidate via automation Jul 16, 2021
pieh
pieh approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@LekoArts LekoArts merged commit 7df39aa into master Jul 19, 2021
@LekoArts LekoArts deleted the vladar/unfit-flag-warning branch July 19, 2021 12:14
@gatsbybot gatsbybot mentioned this pull request Jul 19, 2021
Merged
LekoArts pushed a commit that referenced this pull request Jul 19, 2021
@vladar @LekoArts
feat(gatsby): display message about unfit flags found in config (#32394)
a8b9e1b 
(cherry picked from commit 7df39aa)
@LekoArts LekoArts moved this from To cherry-pick to Backport PR opened in Release candidate Jul 19, 2021
LekoArts pushed a commit that referenced this pull request Jul 19, 2021
@vladar
feat(gatsby): display message about unfit flags found in config (#32394…
7499b22 
…) (#32424)

(cherry picked from commit 7df39aa)

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
@LekoArts LekoArts moved this from Backport PR opened to Backported in Release candidate Jul 19, 2021
This was referenced Oct 1, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
No open projects
Release candidate
Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladar @pieh @LekoArts