fix(gatsby): leave xmlns element when optimizing SVGs
#32123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: webpack/babel
LekoArts
changed the title
xmlns element when optimizing SVGsxmlns element when optimizing SVGs
LekoArts
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Thanks! In their default config it's also disabled https://github.com/svg/svgo#built-in-plugins
|
Published in |
LekoArts
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 27c01fc)
sdorra
added a commit
to scm-manager/website
that referenced
this pull request
Jun 29, 2021
Add a patch for gatsby 3.8 which fixes broken svg background images. See gatsbyjs/gatsby#32123 for more details.
LekoArts
pushed a commit
that referenced
this pull request
Jun 29, 2021
) (cherry picked from commit 27c01fc) Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix SVGs in CSS files by implementing solution described by @nakedible-p in the issue descussion.
Documentation
This is a small code fix, I don't think we need to update any documentation.
Related Issues
Fixes #31878
Fixes #31876
Fixes #32058
Related to #31620