Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-shopify): set default salesChannel to empty string #32044

Merged
merged 1 commit into from Jun 22, 2021

Conversation

DanielSLew
Copy link
Contributor

Description

We need a fallback of an empty string for the salesChannel otherwise it throws an error when the sales channel env variable is not present.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 22, 2021
@DanielSLew DanielSLew added this to To cherry-pick in V3 Release Hotfixes via automation Jun 22, 2021
@DanielSLew DanielSLew added topic: source-shopify Related to the gatsby-source-shopify plugin and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 22, 2021
@DanielSLew DanielSLew merged commit f10554a into master Jun 22, 2021
@DanielSLew DanielSLew deleted the fix-default-value branch June 22, 2021 22:14
@vladar vladar moved this from To cherry-pick to Backport PR opened in V3 Release Hotfixes Jun 23, 2021
vladar pushed a commit that referenced this pull request Jun 23, 2021
gatsbybot pushed a commit that referenced this pull request Jun 23, 2021
(cherry picked from commit f10554a)

Co-authored-by: Daniel Lew <51924260+DanielSLew@users.noreply.github.com>
@vladar
Copy link
Contributor

vladar commented Jun 23, 2021

Published in gatsby-source-shopify@5.0.1

@LekoArts LekoArts moved this from Backport PR opened to Backported in V3 Release Hotfixes Jun 29, 2021
@LekoArts LekoArts moved this from Backported to Published in V3 Release Hotfixes Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-shopify Related to the gatsby-source-shopify plugin
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants