Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 0.14 and React Router 1.0 #32

Closed
KyleAMathews opened this issue Sep 13, 2015 · 15 comments
Closed

Upgrade to React 0.14 and React Router 1.0 #32

KyleAMathews opened this issue Sep 13, 2015 · 15 comments
Labels
help wanted Issue with a clear description that the community can help with.

Comments

@KyleAMathews
Copy link
Contributor

If someone wants to grab this, this would be an easy first PR.

@KyleAMathews KyleAMathews added the help wanted Issue with a clear description that the community can help with. label Sep 13, 2015
@gesposito
Copy link
Contributor

Upgrade guide here.

@phlogisticfugu
Copy link
Contributor

am interested in working on this one. @KyleAMathews, looks like, for react-router, the files to edit are static-entry and web-entry. Is that right?

Also, do you want to wait until actual releases? or have an implementation that uses the rc1 of each?

@KyleAMathews
Copy link
Contributor Author

That'd be great! Yeah those two +
https://github.com/gatsbyjs/gatsby/blob/master/lib/isomorphic/create-routes.coffee
which
is where React Routes are actually created. Everything else should stay
the same. Feel free to convert things to ES6 if you'd like as you go.

Thanks! Looking forward to your PR.

Oh and on timing, let's wait to do an actual release when both of their
1.0s are released. Perhaps do our own rc release if they're taking their
times.

On Thu, Sep 17, 2015 at 10:23 AM Phlogistic Fugu notifications@github.com
wrote:

am interested in working on this one. @KyleAMathews
https://github.com/KyleAMathews, looks like, for react-router, the
files to edit are static-entry and web-entry. Is that right?

Also, do you want to wait until actual releases? or have an implementation
that uses the rc1 of each?


Reply to this email directly or view it on GitHub
#32 (comment).

@gesposito
Copy link
Contributor

API shouldn't change while they move out from -rc, should they?

@phlogisticfugu
Copy link
Contributor

Re: ES6 conversion
Thanks, yeah I prefer JS/ES6 to coffeescript actually, but didn't want to rock the boat unnecessarily.

Re: releases and rc1
Yep it wouldn't quite be right to have a "production" release that has "non-production" dependencies. How about a new branch: react-router-v1.0 for work on this until the official release?

@KyleAMathews
Copy link
Contributor Author

The API shouldn't change no. I'm more concerned about potential bugs. But also as far as Gatsby is concerned, users of gatsby are pretty insulated from both router and react so upgrading is more of a keeping up with times than any major improvements.

Well other than code splitting on routes. That'll be very nice as people start to build bigger sites on gatsby.

@KyleAMathews
Copy link
Contributor Author

There's an issue already btw for code splitting #10

Also @phlogisticfugu converting to ES6 is the plan so not at all boat rocking :) @gesposito has actually been converting the starter sites + wrapper components recently.

@knowbody
Copy link

Hey @KyleAMathews I can work on react router upgrade. Should I just send a PR?

@KyleAMathews
Copy link
Contributor Author

Thanks @knowbody!

@phlogisticfugu
Copy link
Contributor

Yep sorry I didn't end up submitting a PR, things have gotten hectic so I haven't gotten to playing with this. glad to see you jumping in @knowbody !

@bartekus
Copy link
Contributor

#111
I'm in the process of finalizing the complete upgrade which included ES6 as well as newest React-router & Babel 6 + other improvements

@KyleAMathews
Copy link
Contributor Author

@knowbody how close is RR 2.0 to landing?

@gesposito
Copy link
Contributor

@gesposito
Copy link
Contributor

@KyleAMathews
Copy link
Contributor Author

0.8 has React-Router 2.0 now 🎉

This was referenced Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with.
Projects
None yet
Development

No branches or pull requests

5 participants